[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND][PATCH][RFC] usb-wacom.c merge into usb-hid.c (
|
From: |
François Revol |
|
Subject: |
Re: [Qemu-devel] [RESEND][PATCH][RFC] usb-wacom.c merge into usb-hid.c (fwd) |
|
Date: |
Tue, 31 Mar 2009 16:40:38 +0200 CEST |
> On Tuesday 31 March 2009, François Revol wrote:
> > ping ?
>
> There seem to be several unrelated name changes, and several bits of
> commented
> out code. The latter is always wrong. Disabled code just bitrots.
> Either fix
> it, or replace it with a comment describing whatever that code was
> supposed
> to indicate.
The names were different in usb-wacom (HID_GET_* instead of GET_*), and
those seemed cleaner to use. Simple :%s/// in vim.
The first commented line is due to an identical value in the case that
I wanted to advertise, and it's why it's tagged [RFC].
The other commented line is just the name of the device, I think I
was't sure which to have here, RFC too.
François.