|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH] Document Qemu coding style |
Date: | Tue, 31 Mar 2009 16:31:03 +0300 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
David Turner wrote:
Very frankly, I don't think that a coding style, even strictly applied, is going to make the QEMU codeeasier to understand.
The coding style is not intended to make the code clearer, just to make it more uniform.
The real barriers to understanding are the lack of structure in the code, liberal use of global macros scattered randomly in the source code, exceedingly liberally named functions, and sometimes obscure implementation of simple concepts (*cough* CharDriverState), cramming totally unrelated stuff in single largish source files (vl.c for the win !), and a blatant lack of documentation comments for a lot of subtlestuff in there to explain the magic.
This is the QEMU coding style.Seriously, what you say is largely true, but the way to fix it is to sent patches or to review posted patches. Nothing else will make a difference.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |