[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] vnc: throttle screen updates.
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] vnc: throttle screen updates. |
Date: |
Thu, 19 Mar 2009 17:25:52 +0000 |
User-agent: |
Thunderbird 2.0.0.14 (X11/20080505) |
Gerd Hoffmann wrote:
> Hi,
>
> This patch makes the vnc server code skip screen refreshes in case
> there is data in the output buffer. This reduces the refresh rate to
> throttle the bandwidth needed in case the network link is saturated.
>
I like the idea behind this patch, but I would make force_update an
unsigned integer instead of a boolean, incrementing it every time we get a
framebuffer_update_request and decrementing it every time we send a
reply.
Secondly we could even move vga_hw_update after:
if (vs->output.offset && !vs->audio_cap && !vs->force_update)