Re: [Qemu-devel] [PATCH][RFC] Handling ':' on filenames

[Amit Shah]

On (Mon) Mar 09 2009 [11:27:53], Eduardo Habkost wrote:
> > > +
> > > +    /* Protocol name will never start with a slash.
> > > +     * This allows the user to specify absolute filenames
> > > +     * containing a ":" character.
> > > +     */
> > > +    if (*filename == '/')
> > > +        return &bdrv_raw;
> > 
> > 3. The patch limits protocols names to not start with '/' (full paths).
> >     I think we should apply the same logic to relative paths, so
> >     protocol names would not start with '.' as well (no protocol
> >     starts with '.' today):
> > 
> >   +   if ((*filename == '/') || (*filename == '.'))
> >   +       return &bdrv_raw;
> 
> Is ':' a valid character for Windows filenames? In this case, we
> may want to check for backslashes also.

I guess so; full paths are (at least used to be) something like
"C:\some-dir\some-file"

Amit