|
From: | Paul Brook |
Subject: | Re: [Qemu-devel] [6798] tcg: optimize nor(X, Y, Y), used on PPC for not(X, Y) |
Date: | Tue, 10 Mar 2009 01:30:49 +0000 |
User-agent: | KMail/1.9.9 |
On Monday 09 March 2009, Aurelien Jarno wrote: > + if (GET_TCGV_I32(arg1) != GET_TCGV_I32(arg2)) { This should be TCGV_EQUAL_I32[1]. IMHO any use of GET_TCGV outside of tcg/ is wrong[2]. > + if (GET_TCGV_I64(arg1) != GET_TCGV_I64(arg2)) { Likewise. Paul [1] It doesn't exist yet, but TCGV_EQUAL does. [2] target-arm/translate.c is the chief offender. My excuse is that I wrote that code before tcg_temp_free existed.
[Prev in Thread] | Current Thread | [Next in Thread] |