Re: [HaikuPorts-devs] [Qemu-devel] Re: [PATCH] [RFC] Haiku host support and general configure issues

[Avi Kivity]

François Revol wrote:
> > We could define a qemu_errno() which returns errno converted to 
> > positive 
> > numbers.  While it will touch a lot of places, I don't think it can 
> > be 
> > considered invasive.
> >     
>
> I'm used to using the opposite, RETERR() returning always negative 
> codes from either errno or E*, and it works quite well.
>
> I don't see the point in making stuff positive to return them negated.
>   

Changing errno to qemu_errno() is not an invasive change (at least, not 
much).  Adding a RETERR() is, with significant chance for regressions.

> Besides, one of the error codes in BeOS & Haiku will certainly overflow 
> on 32bit (B_NO_MEMORY = B_GENERAL_ERROR_BASE = LONG_MIN).
>   

qemu_errno() on Haiku could change it to something else.

--
error compiling committee.c: too many arguments to function