|
From: | Robert Reif |
Subject: | Re: [Qemu-devel] [5849] Change MMIO callbacks to use offsets, not absolute addresses. |
Date: | Mon, 23 Feb 2009 07:42:55 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.19) Gecko/20081204 SeaMonkey/1.1.14 |
Paul Brook wrote:
On Monday 23 February 2009, Robert Reif wrote:Paul Brook wrote:Revision: 5849 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5849 Author: pbrook Date: 2008-12-01 18:59:50 +0000 (Mon, 01 Dec 2008) Log Message: ----------- Change MMIO callbacks to use offsets, not absolute addresses. Signed-off-by: Paul Brook <address@hidden>This patch breaks sparc illegal access fault handling because the address of the fault is no longer available, only the offset.Really? DEBUG_UNASSIGNED prints the expected values for ARM targets, and the sparc code looks like it should be using the same value.Paul
in exec.c static uint32_t unassigned_mem_readb(void *opaque, target_phys_addr_t addr) { #ifdef DEBUG_UNASSIGNED printf("Unassigned mem read byte " TARGET_FMT_plx "\n", addr); #endif #if defined(TARGET_SPARC) do_unassigned_access(addr, 0, 0, 0, 1); #endif return 0; }addr is now the offset rather than the physical address and it is passed to do_unassigned_access which then puts the offset into the fault address register.
[Prev in Thread] | Current Thread | [Next in Thread] |