qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings


From: Stuart Brady
Subject: Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings
Date: Sat, 21 Feb 2009 23:03:59 +0000
User-agent: Mutt/1.5.13 (2006-08-11)

On Sat, Feb 21, 2009 at 08:00:55PM +0100, Jan Kiszka wrote:
> diff --git a/target-cris/translate.c b/target-cris/translate.c
> index f575e63..954b038 100644
> --- a/target-cris/translate.c
> +++ b/target-cris/translate.c
> @@ -2613,7 +2613,7 @@ static unsigned int dec_move_pm(DisasContext *dc)
>  static unsigned int dec_movem_mr(DisasContext *dc)
>  {
>       TCGv_i64 tmp[16];
> -        TCGv tmp32;
> +        TCGv tmp32 = 0;
>       TCGv addr;
>       int i;
>       int nr = dc->op2 + 1;

Hmm, GCC just gets it wrong here -- and 0 isn't really very meaningful.
At the very least, shouldn't there be a comment?  Something like Linux's
uninitialized_var() macro might be worth considering...
-- 
Stuart Brady




reply via email to

[Prev in Thread] Current Thread [Next in Thread]