[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Generate PCI hotplug interrupt only if corespon
From: |
Marcelo Tosatti |
Subject: |
Re: [Qemu-devel] [PATCH] Generate PCI hotplug interrupt only if corespondent EN bit is set. |
Date: |
Mon, 16 Feb 2009 12:42:57 -0300 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
ACK
On Thu, Feb 12, 2009 at 10:10:36AM +0200, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov <address@hidden>
> ---
>
> hw/acpi.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/acpi.c b/hw/acpi.c
> index 5eac1ad..2375f20 100644
> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -724,27 +724,27 @@ void qemu_system_hot_add_init(void)
> static void enable_device(struct pci_status *p, struct gpe_regs *g, int slot)
> {
> g->sts |= 2;
> - g->en |= 2;
> p->up |= (1 << slot);
> }
>
> static void disable_device(struct pci_status *p, struct gpe_regs *g, int
> slot)
> {
> g->sts |= 2;
> - g->en |= 2;
> p->down |= (1 << slot);
> }
>
> void qemu_system_device_hot_add(int bus, int slot, int state)
> {
> - qemu_set_irq(pm_state->irq, 1);
> pci0_status.up = 0;
> pci0_status.down = 0;
> if (state)
> enable_device(&pci0_status, &gpe, slot);
> else
> disable_device(&pci0_status, &gpe, slot);
> - qemu_set_irq(pm_state->irq, 0);
> + if (gpe.en & 2) {
> + qemu_set_irq(pm_state->irq, 1);
> + qemu_set_irq(pm_state->irq, 0);
> + }
> }
>
> struct acpi_table_header
>
>