Re: [Qemu-devel] [PATCH 07/14] Add v{add,sub}fp instructions

[Nathan Froyd]

On Tue, Feb 03, 2009 at 08:52:48PM +0100, Aurelien Jarno wrote:
> On Thu, Jan 22, 2009 at 12:44:07PM -0800, Nathan Froyd wrote:
> > +void helper_vsubfp (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
> > +{
> > +    int i;
> > +    for (i = 0; i < ARRAY_SIZE(r->f); i++) {
> > +        HANDLE_NAN2(r->f[i], a->f[i], b->f[i]) {
> > +            if (unlikely(float32_is_infinity(a->f[i]) &&
> > +                         float32_is_infinity(b->f[i]) &&
> > +                         float32_is_neg(a->f[i]) == 
> > float32_is_neg(b->f[i]))) {
> > +                /* Magnitude subtraction of infinities */
> > +                r->u32[i] = 0x7fc00000;
> 
> I think this case is already handled by the softfloat code.

Ah, hm, I think you may be right.  That's what I get for cargo-culting
the code from the existing float helpers. :)

This means I don't have to separate v{add,sub}fp, either.  I'll resubmit
this one; I don't think any of the other patches in the series will
conflict.

-Nathan