qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit cap


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] don't expose lm bit if kernel is not 64-bit capable.
Date: Tue, 03 Feb 2009 11:58:49 -0600
User-agent: Thunderbird 2.0.0.19 (X11/20090105)

Glauber Costa wrote:
On Tue, Feb 3, 2009 at 1:44 PM, Alexander Graf <address@hidden> wrote:
This doesn't really compile on win32, does it?
This is kvm code, and as we don't have kvm for win32 hosts, possibly
does not matter.

Would be better to use a kvm accessor to wrap this functionality. kvm_is_lmkernel() or something. Makes things more obviously portable on another platform.

Regards,

Anthony Liguori

Why not check for sizeof(long) == 4? That way you'd know that you're running
32-bit code which can only handle 32-bit guests anyway, right? And if you're
running 64-bit userspace code, you know that the kernel is 64-bit aware.

How about qemu/kvm compiled in a 32-bit environment, thus, sizeof long == 4,
running in a x86_64 capable kernel?






reply via email to

[Prev in Thread] Current Thread [Next in Thread]