qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Fix -sizeof(foo) in target-arm/neon_helper.c shift helpers


From: Julian Brown
Subject: [Qemu-devel] Fix -sizeof(foo) in target-arm/neon_helper.c shift helpers
Date: Tue, 27 Jan 2009 17:47:32 +0000

This patch fixes some bogus comparisons in the helpers for ARM NEON
shift operations, which negate sizeof(foo) without taking into account
that the result of that expression is unsigned.

I have no qemu write access, so can someone apply this for me if OK?

Thanks,

Julian

ChangeLog

    * target-arm/neon_helper.c (shl_u8, shl_u16, shl_u32): Fix
    greater-than-element-size boundary condition.
    (shl_s8, shl_s16, shl_s32): Likewise.
    (rshl_s8, rshl_s16, rshl_s32, rshl_u8, rshl_u16, rshl_u32)
    (qshl_s8, qshl_s16, qshl_s32, qshl_u8, qshl_u16, qshl_u32): Add
    casts to uses of -sizeof(), fix boundary conditions.

Attachment: neon-minus-sizeof-fixes-2.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]