Re: [Qemu-devel] [6380] Make make output quieter (Avi Kivity)

[Stuart Brady]

On Wed, Jan 21, 2009 at 06:13:09PM +0000, Anthony Liguori wrote:
> Spew out less noise when compiling.  This helps review make output for
> information such as compilation warnings, rather than extra long compiler
> invocations.
> 
> The full output can be generated by supplying a 'V=1' parameter to make.

Excellent!

However, I would find it helpful to see the name of the target that is
being built.  Something like the following? ...

Signed-off-by: Stuart Brady <address@hidden>

Index: rules.mak
===================================================================
--- rules.mak   (revision 6417)
+++ rules.mak   (working copy)
@@ -1,19 +1,19 @@
 
 %.o: %.c
-       $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<,CC $@)
+       $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<,CC 
$(TARGET_DIR) $@)
 
 %.o: %.S
-       $(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,AS $@)
+       $(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,AS $(TARGET_DIR) $@)
 
 %.o: %.m
-       $(call quiet-command,$(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<,OBJC $@)
+       $(call quiet-command,$(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<,OBJC 
$(TARGET_DIR) $@)
 
-LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS),LINK $@)
+LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS),LINK 
$(TARGET_DIR) $@)
 
 %$(EXESUF): %.o
        $(LINK)
 
 %.a:
-       $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,AR $@)
+       $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,AR $(TARGET_DIR) $@)
 
 quiet-command = $(if $(V),$1,@echo $2 && $1)
Index: Makefile
===================================================================
--- Makefile    (revision 6417)
+++ Makefile    (working copy)
@@ -8,6 +8,7 @@
 
 VPATH=$(SRC_PATH):$(SRC_PATH)/hw
 
+TARGET_DIR=common
 
 CFLAGS += $(OS_CFLAGS) $(ARCH_CFLAGS)
 LDFLAGS += $(OS_LDFLAGS) $(ARCH_LDFLAGS)
@@ -39,7 +40,7 @@
 SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
 
 subdir-%:
-       $(MAKE) -C $(subst subdir-,,$@) V="$(V)" all
+       $(MAKE) -C $(subst subdir-,,$@) V="$(V)" TARGET_DIR="$*" all
 
 $(filter %-softmmu,$(SUBDIR_RULES)): libqemu_common.a
 $(filter %-user,$(SUBDIR_RULES)): libqemu_user.a

Or is there a cleaner way of doing this?

(BTW, could the $(subst subdir-,,$@) just be replaced with $*?)

Cheers,
-- 
Stuart Brady