[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events
From: |
Laurent Desnogues |
Subject: |
Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events |
Date: |
Fri, 16 Jan 2009 13:12:39 +0100 |
On Fri, Jan 16, 2009 at 1:14 PM, Kevin Wolf <address@hidden> wrote:
[..]
>> @@ -159,6 +159,12 @@ static void cpu_reset_model_id(CPUARMState *env,
>> uint32_t id)
>> void cpu_reset(CPUARMState *env)
>> {
>> uint32_t id;
>> +
>> + if (qemu_loglevel_mask(CPU_LOG_RESET)) {
>> + fprintf(logfile, "CPU Reset (CPU %d)\n", env->cpu_index);
>> + cpu_dump_state(env, logfile, fprintf, 0);
>
> Shouldn't that be qemu_log() and log_cpu_state() now?
Yes. Sorry Jan :)
A trick to check things are done properly is to make sure you
don't ever use logfile or loglevel variables.
Laurent
- [Qemu-devel] [RESEND][PATCH 1/2] Log reset events, Jan Kiszka, 2009/01/16
- Re: [Qemu-devel] [RESEND][PATCH 1/2] Log reset events, Laurent Desnogues, 2009/01/16
- [Qemu-devel] Re: [RESEND][PATCH 1/2] Log reset events, Jan Kiszka, 2009/01/16
- [Qemu-devel] [PATCH -v2 1/2] Log reset events, Jan Kiszka, 2009/01/16
- Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events, Kevin Wolf, 2009/01/16
- Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events,
Laurent Desnogues <=
- Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events, Kevin Wolf, 2009/01/16
- Re: [Qemu-devel] [PATCH -v2 1/2] Log reset events, Laurent Desnogues, 2009/01/16
- [Qemu-devel] Re: [PATCH -v2 1/2] Log reset events, Jan Kiszka, 2009/01/16
- [Qemu-devel] Re: [PATCH -v2 1/2] Log reset events, Jan Kiszka, 2009/01/16
- Re: [Qemu-devel] Re: [PATCH -v2 1/2] Log reset events, Kevin Wolf, 2009/01/16
- [Qemu-devel] [PATCH -v3 1/2] Log reset events, Jan Kiszka, 2009/01/16
- Re: [Qemu-devel] [PATCH -v3 1/2] Log reset events, Kevin Wolf, 2009/01/16
- [Qemu-devel] Re: [PATCH -v3 1/2] Log reset events, Jan Kiszka, 2009/01/16