qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] qemu: block.c: introducing "fmt:FMT:" prefix to image-f


From: Kevin Wolf
Subject: Re: [Qemu-devel] qemu: block.c: introducing "fmt:FMT:" prefix to image-filenames
Date: Fri, 09 Jan 2009 10:17:12 +0100
User-agent: Thunderbird 2.0.0.17 (X11/20080922)

Jamie Lokier schrieb:
> Uri Lublin wrote:
>> Daniel P. Berrange wrote:
>>> Yes the format you write into the qcow2 header can still use the 
>>> fmt:qcow2: prefix - just no need to expose that particular qcow2
>>> specific implementation detail on the CLI. 
>> OK. I'll prepare a patch that adds '-F fmt' to 'qemu-img create -b ...'
> 
> Will it break backing files whose filename begins with "fmt:"?
> 
> Just because I hate hidden "some filenames work, some filenames break
> mysteriously, and of course it's not documented" dodgy hacks.

Uri, now that you are making the change in qcow2 instead of block.c,
have you thought about using the earlier suggested "filename.img\0qcow2"
hack? This shouldn't break filenames.

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]