Re: [Qemu-devel] [PATCH] [RFC] sh: SM501 usb host emulation

[Jean-Christophe PLAGNIOL-VILLARD]

On 14:52 Sat 03 Jan     , Shin-ichiro KAWASAKI wrote:
> Shin-ichiro KAWASAKI wrote:
> > Hi, all.
> > 
> > SM501 is a multi function device on sh4/r2d evaluation board.
> > Now, only its minimum graphics feature is implemented.
> > This patch adds SM501's usb host feature.
> > 
> > To use usb keyboard for sh4/r2d system emulation, we need to apply
> > another patch to add PCI usb host.  This patch avoids this work,
> > and provides more precise usb host emultation than PCI one.
> > 
> > Reviews and comments will be appreciated.
> > This patch modifies not only r2d/sm501 related source files but also
> > "hw/usb-ohci.c".  It should not have any impact on other board emulations'
> > usb feature.  Reviews from this point of view will be meaningful.
> 
> I hope the patch to be applied to trunk, because now I believe it has
> no impact for other board emulation, which has PCI usb host or PXA
> usb host.
> 
> I've checked it with following way.
>  - I built sh4/r2d system emulation environment with PCI usb host.
>    Code was taken from qemu svn head and qemu-sh staging quilt repository.
>    And I confirmed that USB keyboard works fine with it.
>  - Applied the SM501 usb host patch to the environment.
>  - Disabled SM501 usb host by killing off following lines in hw/sm501.c
>     /* bridge to usb host emulation module */
>     usb_ohci_init_sm501(base + MMIO_BASE_OFFSET + SM501_USB_HOST, base, 
>                       2, -1, irq);
>  - Booted up the SH-Linux with the environment, and saw how the USB keyboard
>    worked with PCI usb host.
> 
> As a result, PCI usb host works fine under the modification of SM501 usb
> host patch. I didn't checked PXA usb host, but it shares whole codes with
> PCI usb host emulation in "hw/usb-ohci.c".
I agree too

I'll port the usb support on u-boot and test your patch

Best Regards,
J.