Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack

[Carl-Daniel Hailfinger]

On 23.12.2008 20:58, Blue Swirl wrote:
> On 12/23/08, Carl-Daniel Hailfinger <address@hidden> wrote:
>   
>> On 23.12.2008 19:30, Blue Swirl wrote:
>>  > On 12/23/08, Justin Chevrier <address@hidden> wrote:
>>  >
>>  >>  It also appears that the code referenced in the link loops infinitely 
>> due to a missing: "max_sensei--;" which is present in the Linux Kernel's 
>> equivalent code.
>>  >>
>>  >
>>  > This one:
>>  > 
>> http://fxr.watson.org/fxr/source/drivers/block/floppy.c?v=linux-2.4.22;im=bigexcerpts#L1800
>>  >
>>  > Adding max_sensei-- to OpenBIOS allows it to survive your previous
>>  > patch, which caused an infinite loop earlier:
>>  >
>>  > floppy_motor_off
>>  > SENSEI c0 00
>>  > SENSEI c0 00
>>  > SENSEI c0 00
>>  > SENSEI c0 00
>>  > status = 80, reply_buffer= c0 0
>>  >
>>
>>
>> Can you send a patch for this issue to upstream OpenBIOS?
>>     
>
> I've already applied it (r321).
>   

Great, thanks!

Regards,
Carl-Daniel