Re: [Qemu-devel] [6106] Implement default-NaN mode.

[Laurent Desnogues]

On Fri, Dec 19, 2008 at 2:53 PM, Paul Brook <address@hidden> wrote:
> Revision: 6106
>          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6106
> Author:   pbrook
> Date:     2008-12-19 13:53:37 +0000 (Fri, 19 Dec 2008)
>
> Log Message:
> -----------
> Implement default-NaN mode.
>
> Signed-off-by: Paul Brook <address@hidden>
>
> Modified Paths:
> --------------
>    trunk/fpu/softfloat-specialize.h
>    trunk/fpu/softfloat.h
>    trunk/target-arm/helper.c
[...]
> Modified: trunk/target-arm/helper.c
> ===================================================================
> --- trunk/target-arm/helper.c   2008-12-19 13:37:53 UTC (rev 6105)
> +++ trunk/target-arm/helper.c   2008-12-19 13:53:37 UTC (rev 6106)
> @@ -2334,6 +2334,8 @@
>         }
>         set_float_rounding_mode(i, &env->vfp.fp_status);
>     }
> +    if (changed & (1 << 25))
> +        set_default_nan_mode((val & (1 << 25)) != 0, &env->vfp.fp_status);
>
>     i = vfp_exceptbits_to_host((val >> 8) & 0x1f);
>     set_float_exception_flags(i, &env->vfp.fp_status);

Doesn't this require an update to the way flags are computed in
target-arm/cpu.h/cpu_get_tb_cpu_state?

Also I guess the comment at end of vfp_set_fpscr needs some
update to reflect the handling of DN :-)


Laurent