qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/6] Enable KVM for ppcemb.


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 3/6] Enable KVM for ppcemb.
Date: Sat, 13 Dec 2008 21:29:34 -0600
User-agent: Thunderbird 2.0.0.17 (X11/20080925)

Hollis Blanchard wrote:
On Thu, 2008-12-11 at 16:54 -0600, Hollis Blanchard wrote:
I don't know that kvm_ppc.c is a very information name for this sort
of
stuff.  Since this is really host specific, not target specific, why
not
move it out of target-ppc.
I could combine kvm_ppc.c into target-ppc/kvm.c. However, they're
really
two different things, and I thought it would cause the least confusion
if they were logically separate. Most of it is hooks required by
common
code, and then some of it isn't. (I'm thinking about e.g. IA64 doing a
copy/paste, and then wondering which functions they actually need to
implement.) Regardless, I will still need a kvm_ppc.h, so kvm_ppc.c
seemed like a good place to match.

Any further thoughts on this issue? It's the only issue I still have
unresolved from the initial reviews.

No, we can fix it later when someone comes up with a better idea.

Regards,

Anthony Liguori






reply via email to

[Prev in Thread] Current Thread [Next in Thread]