[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Allow to register a callback with fw_cfg_add_ca
|
From: |
Blue Swirl |
|
Subject: |
Re: [Qemu-devel] [PATCH] Allow to register a callback with fw_cfg_add_callback() |
|
Date: |
Thu, 11 Dec 2008 19:33:58 +0200 |
On 12/11/08, Gleb Natapov <address@hidden> wrote:
> On Thu, Dec 11, 2008 at 04:09:28PM +0100, Laurent Vivier wrote:
> > fw_cfg_add_callback() checks if key has FW_CFG_WRITE_CHANNEL bit set
> > after masking the key with FW_CFG_ENTRY_MASK.
> >
> > But as FW_CFG_ENTRY_MASK is ~(FW_CFG_WRITE_CHANNEL | FW_CFG_ARCH_LOCAL),
> > the bit is never set and function exits.
> >
> > This patch corrects this by checking the bit before masking the value.
> >
> > Signed-by-off: Laurent Vivier <address@hidden>
>
> Acked-by: Gleb Natapov <address@hidden>
Thanks, committed in r5978.