[Qemu-devel] Re: [RFC 1/1] pci-dma-api-v2

[Blue Swirl]

On 11/30/08, Andrea Arcangeli <address@hidden> wrote:
> On Fri, Nov 28, 2008 at 07:50:01PM +0100, Andrea Arcangeli wrote:
>  > better. I've also noticed some problems with windows (I didn't test
>  > windows before posting), those aren't related to the cache layer as I
>  > added a #define to disable it and replace it with malloc/free. But
>  > that's not the cache layer, as soon as windows runs completely
>  > flawlessy I post an update.
>
>  As promised here an updated. I fixed all outstanding issues, it's
>  running rock solid. Before there were a few spots on ide.c plus the
>  cache layer was very buggy with more than one dma in-flight.

The patch does not apply as is:
>  --- hw/ide.c    (revision 5818)
>  +++ hw/ide.c    (working copy)
>  diff --git a/qemu/hw/pci_dma.c b/qemu/hw/pci_dma.c
>  new file mode 100644
>  index 0000000..48762a8
>  --- /dev/null
>  +++ b/qemu/hw/pci_dma.c
>  diff --git a/qemu/hw/pci_dma.h b/qemu/hw/pci_dma.h
>  new file mode 100644
>  index 0000000..5cc8413
>  --- /dev/null
>  +++ b/qemu/hw/pci_dma.h

Even as I fixed the patch, it still does not compile, for example:
/src/qemu/block.c:1335: warning: 'struct iovec' declared inside parameter list
/src/qemu/block.c:1336: error: conflicting types for 'bdrv_aio_writev'
/src/qemu/block.h:106: error: previous declaration of 'bdrv_aio_writev' was here
/src/qemu/block.c:1425: error: invalid use of undefined type 'struct iovec'