[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] gdbstub: Fix access to PPC FPRs
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] gdbstub: Fix access to PPC FPRs |
Date: |
Sun, 30 Nov 2008 17:27:18 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Fri, Nov 28, 2008 at 11:01:37AM +0100, Jan Kiszka wrote:
> Obviously, someone forgot to rebase the index before accessing one of
> the 32 FPRs.
>
> Signed-off-by: Jan Kiszka <address@hidden>
Thanks, applied.
>
> gdbstub.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index b522a89..452b7d0 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -428,7 +428,7 @@ static int cpu_gdb_read_register(CPUState *env, uint8_t
> *mem_buf, int n)
> GET_REGL(env->gpr[n]);
> } else if (n < 64) {
> /* fprs */
> - stfq_p(mem_buf, env->fpr[n]);
> + stfq_p(mem_buf, env->fpr[n-32]);
> return 8;
> } else {
> switch (n) {
> @@ -459,7 +459,7 @@ static int cpu_gdb_write_register(CPUState *env, uint8_t
> *mem_buf, int n)
> return sizeof(target_ulong);
> } else if (n < 64) {
> /* fprs */
> - env->fpr[n] = ldfq_p(mem_buf);
> + env->fpr[n-32] = ldfq_p(mem_buf);
> return 8;
> } else {
> switch (n) {
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' address@hidden | address@hidden
`- people.debian.org/~aurel32 | www.aurel32.net