Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute

[Stefan Weil]

Avi Kivity schrieb:
> Jan Kiszka wrote:
>>> Breaking the standard is what brings us the joys of recently (re)posted
>>> patch for NetBSD and [u]intXX fun.
>>>     
>>
>> I have no problem with calling it 'noreturn' instead.
>>   
>
> That will break code that wants to use 'noreturn' as a local
> variable.  I think ATTR_NORETURN, while a lot uglier, is safer.
>
>
>

Why do we need a new macro instead of just using __attribute__
((__noreturn__))?

The macro won't save very much writing, needs an include dependency, breaks
code which uses the same symbol for other purposes, makes code reusage
in other
products more difficult, ...

Stefan