Re: [Qemu-devel] [5780] Native BSD host USB support (Juergen Lock, Lonnie Mendez)

[Blue Swirl]

On 11/24/08, Anthony Liguori <address@hidden> wrote:
> Blue Swirl wrote:
>
> > Revision: 5780
> >
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5780
> > Author:   blueswir1
> > Date:     2008-11-22 21:03:55 +0000 (Sat, 22 Nov 2008)
> >
> > Log Message:
> > -----------
> > Native BSD host USB support (Juergen Lock, Lonnie Mendez)
> >
> >
>
>  This broke the Windows build and cross compiling.  Was this patch posted to
> the list or did you pull it from the URL that Juergen's been posting?

Yes, but maybe you missed it because it was inside a shar package.

>  I would have given the patch a run if it had been posted first and we could
> have avoided the breakage.
>
>
> > Modified: trunk/configure
> >
> ===================================================================
> > --- trunk/configure     2008-11-22 20:49:12 UTC (rev 5779)
> > +++ trunk/configure     2008-11-22 21:03:55 UTC (rev 5780)
> > @@ -221,6 +221,7 @@
> >  audio_possible_drivers="oss alsa sdl esd pa"
> >  linux="yes"
> >  linux_user="yes"
> > +usb="linux"
> >  if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
> >     kqemu="yes"
> >     audio_possible_drivers="$audio_possible_drivers fmod"
> > @@ -231,6 +232,7 @@
> >  if [ "$bsd" = "yes" ] ; then
> >   if [ "$darwin" != "yes" ] ; then
> >     make="gmake"
> > +    usb="bsd"
> >   fi
> >   bsd_user="yes"
> >  fi
> >
> >
>
>  This whole set of checks is horribly broken because it relies on uname -s.
> Such a thing doesn't exist on Windows but more importantly, when cross
> compiling, uname is meaningless.
>
>  What we really should do, is compile a small test program that checks for:
>
>  #ifndef __linux__
>  #error Not linux
>  #endif
>
>  And then try compiling that to see if we're on Linux or not.  The same with
> FreeBSD et al.

In this case we could also check if Linux USB headers or BSD USB
headers are available.

> > Added: trunk/usb-stub.c
> >
> >
>
>  This stub doesn't build at all.  The copyright is a little bogus too
> because I don't think Fabrice, Max, or TJ have ever contributed to this
> file.

Well, before the commit, this code was located at the end of
usb-linux.c which carries this preamble.

> > +
> > +#include "hw/usb.h"
> >
> >
>
>  This is not enough includes to produce something buildable.

Sorry, I missed the headers before #ifdef __linux__.