[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v5 04/18] Refactor and enhance break/watchpoint
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v5 04/18] Refactor and enhance break/watchpoint API |
Date: |
Tue, 18 Nov 2008 23:24:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Anthony Liguori wrote:
> Jan Kiszka wrote:
>> This patch prepares the QEMU cpu_watchpoint/breakpoint API to allow the
>> succeeding enhancements this series comes with.
>>
>> First of all, it overcomes MAX_BREAKPOINTS/MAX_WATCHPOINTS by switching
>> to dynamically allocated data structures that are kept in linked lists.
>> This also allows to return a stable reference to the related objects,
>> required for later introduced x86 debug register support.
>>
>> Breakpoints and watchpoints are stored with their full information set
>> and an additional flag field that makes them easily extensible for use
>> beyond pure guest debugging.
>>
>> Finally, this restructuring lays the foundation for KVM to hook into
>> the debugging infrastructure, providing its own services where hardware
>> virtualization demands it. Once QEMUAccel is considered for merge,
>> those entry point should be included into its abstraction layer so that
>> accellerators can hook in even more cleanly.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>>
>
> I noticed you use an open coded doubly linked list. Can you submit a
> follow-up patch to convert the code to use a TAILQ from sys-queue.h?
>
WIP. Takes a few changes, so a bit more testing is also required. But
this refactoring already uncovered a use-after-release bug in my
original patch.
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 00/18] Enhance debugging support, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 05/18] Set mem_io_vaddr on io_read, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 12/18] Introduce BP_CPU as a breakpoint type, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 03/18] gdbstub: Return appropriate watch message to gdb, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 13/18] x86: Debug register emulation, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 04/18] Refactor and enhance break/watchpoint API, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 15/18] gdbstub: Add vCont support, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 17/18] gdbstub: x86: Support for setting segment registers, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 01/18] Convert CPU_PC_FROM_TB to static inline, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 06/18] Respect length of watchpoints, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 14/18] x86: Dump debug registers, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 11/18] Add debug exception hook, Jan Kiszka, 2008/11/17
- [Qemu-devel] [PATCH v5 10/18] Introduce BP_WATCHPOINT_HIT flag, Jan Kiszka, 2008/11/17