Re: [Qemu-devel] [PATCH v5 00/18] Enhance debugging support

[Anthony Liguori]

Jan Kiszka wrote:
> Here is the latest update after the recent review round. Addressed
> issues:
>   

Applied 1-14.  Thanks for all your work!

I took a pretty detailed look at patch 13.  It seems pretty unlikely to 
me that it could cause regressions since we were basically ignoring 
debug registers before.  I did some extra testing with it too.

15 looks fine but I want to see what the decision is wrt threads vs 
processes.  I think vCont is a good example of why using threads may 
prove better than processes.

I've provided additional comments on 16-18.  Nothing major and if you 
update them, they can be applied quickly.

> PS: If you happen to use git internally, you can also pull the series
> from my private repository:
>
> git://git.kiszka.org/qemu.git gdb-queue
>   

Son of a gun, I wish I would have seen that early.  FYI, in general, if 
people have git repos based on the kernel.org repo, please let me know.  
It's a lot easier for me to pull those patches and git-svn the result 
instead of dealing with exporting mails and pulling them into SVN.

Regards,

Anthony Liguori

> --
> Siemens AG, Corporate Technology, CT SE 2 ES-OS
> Corporate Competence Center Embedded Linux
>
>
>