Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support

[Jean-Christophe PLAGNIOL-VILLARD]

On 23:30 Mon 17 Nov     , François Revol wrote:
> > > -    /* TODO: Implement compressed images.  */
> > > -    if (hdr->ih_comp != IH_COMP_NONE) {
> > > -        fprintf(stderr, "Unable to load compressed u-boot images\
> > > n");
> > > +    /* TODO bzip2 support */
> > > +    if (hdr->ih_comp == IH_COMP_BZIP2) {
> > > +        fprintf(stderr, "Unable to load bzip2 compressed u-boot
> > > images\n");
> > >          goto fail;
> > >      }
> > why do you remove the non compress mode?
> 
> He didn't remove it, he changed the check to only reject BZIP2, not
> uncompressed (which is wrong though as it'd accept any other compession
> including unknown).

I've missed it but as we also support LZMA now you must add the check too
> 
> > BTW Please note 2 thinks
> > First this format of uImage is deprecated
> > we have switch to a fdt uImage format
> 
> fdt ? as in flat device tree ?
> Is that documented somewhere ?
> I'll need to add U-Boot support to Haiku soon...
in the source code doc/uImage.FIT/

I'm preparing the DHT-Walnut

I've add support and doc how to use it for the qemu_mips
and the ARM soon

Best Regards,
J.