Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support

[Hollis Blanchard]

On Mon, 2008-11-17 at 23:07 +0100, Jean-Christophe PLAGNIOL-VILLARD
wrote:
> On 15:18 Mon 17 Nov     , Hollis Blanchard wrote:
> >  /* Load a U-Boot image.  */
> >  int load_uboot(const char *filename, target_ulong *ep, int *is_linux)
> >  {
> > -
> >      int fd;
> >      int size;
> >      uboot_image_header_t h;
> > @@ -374,9 +459,9 @@ int load_uboot(const char *filename, target_ulong *ep, 
> > int *is_linux)
> >          goto fail;
> >      }
> >  
> > -    /* TODO: Implement compressed images.  */
> > -    if (hdr->ih_comp != IH_COMP_NONE) {
> > -        fprintf(stderr, "Unable to load compressed u-boot images\n");
> > +    /* TODO bzip2 support */
> > +    if (hdr->ih_comp == IH_COMP_BZIP2) {
> > +        fprintf(stderr, "Unable to load bzip2 compressed u-boot images\n");
> >          goto fail;
> >      }
> why do you remove the non compress mode?

I do not.

> BTW Please note 2 thinks
> First this format of uImage is deprecated
> we have switch to a fdt uImage format

I see a new "fit" format; I assume this is what you're referring to. Who
is "we"? It looks like Linux does not yet use this format, neither for
PowerPC (my personal interest) nor ARM.

> Secondly we aslo support now LZMA compression

That's good to know, but PowerPC Linux has traditionally and continues
to use gzip uImages, so that's what this patch implements.

-- 
Hollis Blanchard
IBM Linux Technology Center