[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 5/5] monitor: add "info capabilities" command
From: |
Mark McLoughlin |
Subject: |
[Qemu-devel] Re: [PATCH 5/5] monitor: add "info capabilities" command |
Date: |
Fri, 14 Nov 2008 16:02:43 +0000 |
On Thu, 2008-11-13 at 13:50 -0600, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > +static void do_info_capabilities(void)
> > +{
> > + term_printf("[qemu]\n");
> > + list_printf("accel", accel_names);
> > + term_printf("arch=%s\n", TARGET_ARCH);
> > + list_printf("cpu", cpu_names());
> > + machines_printf();
> > +
> > + term_printf("\n");
> > +
> > + do_machine_capabilities();
> > +
> > + term_printf("[devices]\n");
> > + list_printf("bluetooth", bt_list_types());
> > + list_printf("char", qemu_chr_list_types());
> > + list_printf("drive_cache", drive_cache_types());
> > + list_printf("drive_if", drive_if_types());
> > + list_printf("graphics", graphics_list_types());
> > + list_printf("network", net_client_types());
> > +#ifdef HAS_AUDIO
> > + list_printf("soundhw", soundhw_list_types());
> > +#endif
> > + list_printf("vga", vga_list_types());
> > +
> > + term_printf("\n");
> >
>
> This makes me uneasy because it introduces a lot of dependencies that
> are going to be hard to break. I think this level of logic needs to be
> more encapsulated in the various subsystems.
So, something like have [network], [block], [audio] etc. sections and
call out to network_capabilities() etc.?
Cheers,
Mark.
Re: [Qemu-devel] [PATCH 1/5] Re-factor nic model listing, Paul Brook, 2008/11/13