[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/12] Enhance debugging support - 4th take
From: |
Fabrice Bellard |
Subject: |
Re: [Qemu-devel] [PATCH 00/12] Enhance debugging support - 4th take |
Date: |
Thu, 13 Nov 2008 23:06:53 +0100 |
User-agent: |
Thunderbird 1.5.0.9 (X11/20070212) |
I had a quick look at the patch serie (I don't have the time to look at
it carefully). I find the patch globally acceptable, but I have two remarks:
- Patch 01/12 may introduce a performance regression due to the change
in tb_find_fast(). If gcc does not optimizes the code correctly, your
change will introduce many unneeded memory accesses and a call to
memcmp() in the fast path, which is not acceptable.
- Patch 12/12 needs improvements (load/save VM) and possibly more
analysis to see if it complies with the x86 spec, so it could be applied
later.
Regards,
Fabrice.
Jan Kiszka wrote:
> Yet another round for the gdbstub and debug regs patches.
>
> This version addresses the concerns about the next_cflags approach
> brought up by Fabrice and Glauber. Instead of this, the first patch in
> this series takes an alternative path to obtain the required parameters
> for TB generation, see its description for details.
>
> Besides rebasing the series on top of this patch and the latest changes
> in SVN, I addressed Glauber's review comments on take 3 (proper
> description for patch 4, introduce CPUWatchpoint.len_mask directly).
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT SE 2
> Corporate Competence Center Embedded Linux
>
>
>
>
- [Qemu-devel] [PATCH 11/12] Introduce BP_CPU as a breakpoint type, (continued)
- [Qemu-devel] [PATCH 11/12] Introduce BP_CPU as a breakpoint type, Jan Kiszka, 2008/11/03
- [Qemu-devel] [PATCH 08/12] qemu: gdbstub: manage CPUs as threads, Jan Kiszka, 2008/11/03
- [Qemu-devel] [PATCH 09/12] Introduce BP_WATCHPOINT_HIT flag, Jan Kiszka, 2008/11/03
- [Qemu-devel] [PATCH 07/12] Remove premature memop TB terminations, Jan Kiszka, 2008/11/03
- [Qemu-devel] [PATCH 01/12] Refactor translation block CPU state handling, Jan Kiszka, 2008/11/03
- [Qemu-devel] [PATCH 12/12] x86: Debug register emulation, Jan Kiszka, 2008/11/03
- [Qemu-devel] [PATCH 05/12] Respect length of watchpoints, Jan Kiszka, 2008/11/03
- Re: [Qemu-devel] [PATCH 00/12] Enhance debugging support - 4th take, Anthony Liguori, 2008/11/13
- Re: [Qemu-devel] [PATCH 00/12] Enhance debugging support - 4th take,
Fabrice Bellard <=