Re: [Qemu-devel] [5675] target-mips: optimize gen_save_pc()

[Andreas Färber]

Am 11.11.2008 um 12:36 schrieb Aurelien Jarno:

> Revision: 5675
>          http://svn.sv.gnu.org/viewvc/? 
> view=rev&root=qemu&revision=5675
> Author:   aurel32
> Date:     2008-11-11 11:36:04 +0000 (Tue, 11 Nov 2008)
>
> Log Message:
> -----------
> target-mips: optimize gen_save_pc()
>
> We obviously don't need to use a temporary variable to write PC.

We probably don't need an inline helper for that either, while we're  
at it?

Andreas

> Modified: trunk/target-mips/translate.c
> ===================================================================
> --- trunk/target-mips/translate.c       2008-11-11 11:34:39 UTC (rev 5674)
> +++ trunk/target-mips/translate.c       2008-11-11 11:36:04 UTC (rev 5675)
> @@ -827,11 +827,7 @@
>
> static inline void gen_save_pc(target_ulong pc)
> {
> -    TCGv r_tmp = tcg_temp_new(TCG_TYPE_TL);
> -
> -    tcg_gen_movi_tl(r_tmp, pc);
> -    tcg_gen_mov_tl(cpu_PC, r_tmp);
> -    tcg_temp_free(r_tmp);
> +    tcg_gen_movi_tl(cpu_PC, pc);
> }
>
> static inline void save_cpu_state (DisasContext *ctx, int do_save_pc)