[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Move some declarations around in the QEMU C
|
From: |
Blue Swirl |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Move some declarations around in the QEMU CharDriver code |
|
Date: |
Fri, 24 Oct 2008 17:12:13 +0300 |
On 10/23/08, Anthony Liguori <address@hidden> wrote:
> The goal of this series is to move the CharDriverState code out of vl.c and
> into its own file, qemu-char.c. This patch moves around some declarations so
> the next patch can be pure code motion.
Good idea. Do you plan to do this for other things, for example network code?
> -static inline int send_all(int fd, const uint8_t *buf, int len1)
> +inline int send_all(int fd, const uint8_t *buf, int len1)
The 'inline' looks a bit odd without 'static'.