Re: [Qemu-devel] [PATCH][ppc] convert SPE logical instructions to TCG

[Paul Brook]

On Wednesday 15 October 2008 03:09:16 Nathan Froyd wrote:
> +    TCGv t0 = tcg_temp_local_new(TCG_TYPE_I64);                          
>  +    TCGv t1 = tcg_temp_local_new(TCG_TYPE_I64);                    

These should be tcg_temp_new.

Local variables (tcg_temp_local_new) introduce a lot of additional overhead, 
should only be used when absolutely necessary. A local variable is required 
if the value is required to live over multiple basic blocks. i.e. accross a 
branch op or a dyngen op. In the latter case it's probably best to eliminate 
the dyngen op.

Paul