qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Bluetooth options


From: Paul Brook
Subject: Re: [Qemu-devel] Bluetooth options
Date: Sat, 11 Oct 2008 13:06:03 +0100
User-agent: KMail/1.9.9

> > Do we really need 3 different options? Can't everything be done with a
> > single -bt option, like it is with -net?
>
> We can and then the syntax is more like with -net and less like with
> -usbdevice, the attached patch does that instead.

This looks better to me.

> The syntax is now:
> -bt hci,null
> -bt hci,host[:id]

Shouldn't these also have vlan arguments?

> -bt hci[,vlan=N]
> -bt vhci[,vlan=N]
> -bt device:dev[,vlan=N]

I think you're being somewhat inconsistent about the option syntax. Using -bt 
hci for null/"standard" emulated HCI and host hci passthrough but not vhci is 
particularly unintuitive.

The device: qualifier seems like it should be redundant. Unlike USB which is a 
single master bus, bluetooth network topology is peer-peer with master/slave 
roles being negotiated on a per-connection basis.

Is there any point having a "null" HCI? 

I'd expect something along the lines of:

 -bt null[...]
 -bt hci[...]
 -bt vhci[...]
 -bt host[,id=N][...]
 -bt sdp[...]

Obviously this all needs documentation before it is committed ;-)

I'm a little confused what the point of the null hci is. Is this a hci that 
isn't connected to anything else, in which case how is it different to a 
default hci without anything else on the scatternet.  Or is it a dummy test 
device that just rejects all connections attempts, in which case calling it a 
HCI seems misleading.

> > I'd kinda expect serial bluetooth dongles to be added the same way as USB
> > ones, i.e. via -serial options.
>
> The serial dongle emulated in hw/bt-hci-csr.c has some vendor
> extensions so it's not a standard serial dongle.  It's attached by the
> machine code because this part is not configurable in n8x0.  One can
> add support for attaching hot-pluggable serial dongles in vl.c if
> needed.

That sounds like an n8x0 bug. I'm not requiring it be fixed now, but it feels 
like something that should go away.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]