qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [patch 2/2] Add Flash support to the Versatile PB platf


From: Thomas Petazzoni
Subject: Re: [Qemu-devel] [patch 2/2] Add Flash support to the Versatile PB platform
Date: Fri, 10 Oct 2008 15:17:16 +0200

Le Fri, 10 Oct 2008 14:02:17 +0100,
Paul Brook <address@hidden> a écrit :

> > +    if (! hasflash) {
> > +      versatile_binfo.ram_size = ram_size;
> 
> This should be dependent on the presence of the -kernel option, not
> the absence of flash.

Yes, makes sense. How should it behave when neither -kernel nor -pflash
are present ? Just display an error message and exit ?

Thanks a lot for your feedback,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com




reply via email to

[Prev in Thread] Current Thread [Next in Thread]