Re: [Qemu-devel] [Patch 3/4] [RFC] Zero Cluster Dedup, Offline dedup, qemu-img extentions

[Daniel P. Berrange]

On Mon, Oct 06, 2008 at 10:31:39AM -0700, Shahar Frank wrote:
> MDSUM Extension for the map verb
> 
> Signed-off-by: Shahar Frank <address@hidden>
> 
> @@ -496,6 +501,7 @@ elif [ "$bsd" = "yes" ]; then
>  else
>      # Some Linux architectures (e.g. s390) don't imply -lpthread
> automatically.
>      AIOLIBS="-lrt -lpthread"
> +    MD5SUMLIBS="-lssl"
>  fi
>  
>  # Check for gcc4, error if pre-gcc4
> @@ -920,6 +926,20 @@ EOF

We're already linking to GCrypt/GNUTLS for SSL stuff in the VNC server, and
one crypto/SSL library per application really ought to be enough. GCrypt
has APIs for doing md5 hashing (and pretty much every other hashing algo
you can think of). Furthermore, OpenSSL's licensing terms are commonly 
considered to be incompatible with the GPL, unless you add an explicit
exception allowing linking to OpenSSL.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|