Re: [Qemu-devel] [PATCH] USB over network

[Blue Swirl]

On 10/6/08, Gal Hammer <address@hidden> wrote:
> Attached is a preliminary  patch which add QEmu the ability to use local USB
> devices over network. It should work with DOK devices and might work with
> web cameras.

How about USB drives or printers, do they work?

A few comments:
- 'static' can be applied to a lot of functions
- instead of including linux/usb_ch9.h, you should define the
structures, like in usb-linux.c
- while the daemon is linux specific, the remote protocol looks like
host OS neutral, so it should not be too tightly tied to usb-linux.c
- name __ioctl looks like it could clash with system defines and it's
not very descriptive
- USB_REMOTE_MAGIC is not endian neutral, or is that the purpose?
- upper-case structure names are IMHO ugly

Otherwise, great idea!