qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH]: Display TCGCond name in tcg dumper


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH]: Display TCGCond name in tcg dumper
Date: Tue, 9 Sep 2008 18:00:12 +0100
User-agent: KMail/1.9.9

> >  currently TCGCond are displayed by value in tcg dumps - which is not
> > very easy to read.
> >  This patch displays names instead.
>
> The brconds look much better with your patch. Anybody mind if I apply this?

It's a bit of an ugly hack. However I can't immediately see a cleaner 
solution.

> fprintf(outfile, ",%s", cond_name[args[k++]]);

This needs bounds checking in case we generate a bogus condition.

Other than that, ok.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]