Re: [Qemu-devel] [PATCH, RFC] ld flag --warn-common

[Blue Swirl]

On 9/9/08, Blue Swirl <address@hidden> wrote:
> On 9/9/08, Ben Taylor <address@hidden> wrote:
>  > On Sun, Sep 7, 2008 at 8:30 AM, Blue Swirl <address@hidden> wrote:
>  >  > On 9/7/08, Ben Taylor <address@hidden> wrote:
>  >  >> On Sun, Sep 7, 2008 at 4:24 AM, Blue Swirl <address@hidden> wrote:
>  >  >>  > Hi,
>  >  >>  >
>  >  >>  > These trivial patches enable linker flag --warn-common and fix the
>  >  >>  > warnings caused by enabling the flag.
>  >  >>  >
>  >  >>  > I think on some platforms (Solaris?) the linker used by gcc is not 
> GNU
>  >  >>  > ld. If this is true, the patch would break compilation on those 
> hosts
>  >  >>  > and logic in configure would need to be more complex. Please 
> confirm.
>  >  >>
>  >  >>
>  >  >> yes, Solaris does not use gnu ld, it uses it's own linker.
>  >  >
>  >  > Could you test if with this patch applied, "other ld" is printed when
>  >  > configuring?
>  >
>  >
>  > Confirmed that it prints "other ld" on Solaris.
>
>
> Thanks for testing, I'll prepare an updated version.

Here they are. I think I'll commit them in a few days unless there are
objections.

ld_warn_common.diff
Description: plain/text

fix_ld_warn_common.diff
Description: plain/text