[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/6] Use IO port for qemu<->guest BIOS commun
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/6] Use IO port for qemu<->guest BIOS communication. |
Date: |
Mon, 8 Sep 2008 08:39:17 +0300 |
I suppose you are referring to "cpu speed" patch.
> I think this is missing save/restore support. What happens if you do a
> save, move to a different machine, then do a restore, and reboot? The
> guest will see a different value IIUC.
>
I don't think that getting a different value in SMBIOS tables after reboot
is problematic. It may change on real HW too I think. Because of power
saving on a laptop for instance.
> Also, instead of returning 0 on non-linux systems, why not just return
> some fixed value? It's no more "wrong" than returning the host clock
> rate.
>
I am OK with that. What value do you propose?
I'll resent a whole series. Let's move discussion there. And if there is
no more comments about other parts of the series can we apply it finally?
--
Gleb.