|
From: | Avi Kivity |
Subject: | [Qemu-devel] Re: [PATCH] Fix up pxe boot |
Date: | Tue, 02 Sep 2008 11:39:13 +0300 |
User-agent: | Thunderbird 2.0.0.16 (X11/20080723) |
Glauber Costa wrote:
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c index 0b5fdc0..433aa3f 100644 --- a/target-i386/op_helper.c +++ b/target-i386/op_helper.c @@ -600,7 +600,7 @@ do {\ #define PUSHL(ssp, sp, sp_mask, val)\ {\ sp -= 4;\ - stl_kernel((ssp) + (sp & (sp_mask)), (val));\ + stl_kernel((uint32_t)((ssp) + (sp & (sp_mask))), (uint32_t)(val));\ }
Surly it is better to push this into the underlying virtual->physical translation functions, so it applies everywhere?
btw, the cast is wrong for x86-64, so it must be qualified for 32-bit operating modes.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |