[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS commun
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication. |
Date: |
Sun, 31 Aug 2008 14:40:00 +0300 |
On 8/31/08, Gleb Natapov <address@hidden> wrote:
> On Sat, Aug 30, 2008 at 10:57:34PM +0300, Blue Swirl wrote:
> > On 8/29/08, Gleb Natapov <address@hidden> wrote:
> > > On Thu, Aug 28, 2008 at 09:04:11PM +0300, Blue Swirl wrote:
> > > > On 8/28/08, Gleb Natapov <address@hidden> wrote:
> > > > > + fw_cfg_add(fw_cfg, FW_CFG_ID, (uint8_t *)&bios_cfg_id,
> > > > > + sizeof(bios_cfg_id));
> > > >
> > > > On second thought, this is in host byte order, which is not a good
> idea.
> > > >
> > >
> > > Is there some function to convert from host byte order to target byte
> > > order?
> >
> > I made an updated version of the patch 1/6, with explicit little
> > endian conversions. I'm not very happy with that. Another way would be
> > to add functions just to put different size numbers into device and
> > they would hide the conversion.
> >
>
> So what approach we should go with? We can go with the second one (add
> functions for each type) and extend interface as needed.
Okay, I'll make a new version.
- [Qemu-devel] [PATCH v3 0/6] Add UUID command-line option, Gleb Natapov, 2008/08/28
- [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/28
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/28
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/28
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/29
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/29
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/30
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication.,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Blue Swirl, 2008/08/31
- Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS communication., Gleb Natapov, 2008/08/31
[Qemu-devel] [PATCH v3 2/6] Add -uuid command line option., Gleb Natapov, 2008/08/28
[Qemu-devel] [PATCH v3 3/6] Add "info uuid" command to monitor., Gleb Natapov, 2008/08/28
[Qemu-devel] [PATCH v3 4/6] Use libuuid if available., Gleb Natapov, 2008/08/28
[Qemu-devel] [PATCH v3 5/6] Add UUID to firmware configuration info., Gleb Natapov, 2008/08/28