qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] Introduce #define QEMU_ASYNC_EVENTLOOP to s


From: Ian Jackson
Subject: Re: [Qemu-devel] [PATCH 2/2] Introduce #define QEMU_ASYNC_EVENTLOOP to simplify #ifdefs
Date: Fri, 29 Aug 2008 10:31:10 +0100

Anthony Liguori writes ("Re: [Qemu-devel] [PATCH 2/2] Introduce #define 
QEMU_ASYNC_EVENTLOOP to simplify #ifdefs"):
> I don't understand why we need two defines in the first place.  I 
> noticed in the Makefile that we have rules to build qemu-nbd- objects 
> and qemu-img- objects, but I don't see why that should be necessary.

Well, the original #define was called QEMU_IMG and the objects were
called qemu-img-*.  Surely we didn't expect Laurent to reuse those ?
The names clearly indicated not to.

Perhaps it would be better to reorganise this some more and have
qemu-syncioutil-*.o but I think to avoid the best being the enemy of
the good I would argue that my patch should be applied in the
meantime.

Ian.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]