Re: [Qemu-devel] [5076] VNC: Support for ExtendedKeyEvent client message

[Alexander Graf]

On Aug 24, 2008, at 1:27 AM, Anthony Liguori wrote:

> Revision: 5076
>          http://svn.sv.gnu.org/viewvc/? 
> view=rev&root=qemu&revision=5076
> Author:   aliguori
> Date:     2008-08-23 23:27:37 +0000 (Sat, 23 Aug 2008)
>
> Log Message:
> -----------
> VNC: Support for ExtendedKeyEvent client message
>
> This patch adds support for the ExtendedKeyEvent client message.   
> This message
> allows a client to send raw scan codes directly to the server.  If  
> the client
> and server are using the same keymap, then it's unnecessary to use  
> the '-k'
> option with QEMU when this extension is supported.
>
> This is extension is currently only implemented by gtk-vnc based  
> clients
> (gvncviewer, virt-manager, vinagre, etc.).
>
> Signed-off-by: Anthony Liguori <address@hidden>
>
> Modified Paths:
> --------------
>    trunk/vnc.c

[...snip...]


> static void set_encodings(VncState *vs, int32_t *encodings, size_t  
> n_encodings)
> {
>     int i;
> @@ -1105,6 +1124,9 @@
>         case -257:
>             vs->has_pointer_type_change = 1;
>             break;
> +        case -258:
> +            send_ext_key_event_ack(vs);
> +            break;
>         default:
>             break;
>         }
> @@ -1256,6 +1278,24 @@
>
>         client_cut_text(vs, read_u32(data, 4), data + 8);
>         break;
> +    case 255:
> +        if (len == 1)
> +            return 2;
> +
> +        switch (read_u8(data, 1)) {
> +        case 0:

How do you standardize VNC protocol extensions? I've been wondering  
about this for quite a while as I've got two VNC patches in my queue  
myself.
The first one allows the client to send a keyboard layout (so the -k  
option could be changed dynamically, mostly because the Java client  
can't find symcodes).
The other one implements PNG compression for Tight.

I'd really love to have both of them standardized, but where do I need  
to apply for an identifier ID?

[...snip...]

Thanks,

Alex