Re: [Qemu-devel] [5083] PPC: Switch a few instructions to TCG

[Andreas Färber]

Am 25.08.2008 um 00:08 schrieb J. Mayer:

> On Sun, 2008-08-24 at 19:05 +0000, Aurelien Jarno wrote:
> > Revision: 5083
> >          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5083
> > Author:   aurel32
> > Date:     2008-08-24 19:05:35 +0000 (Sun, 24 Aug 2008)
> >
> > Log Message:
> > -----------
> > PPC: Switch a few instructions to TCG
>
> It seems like you forgot to consider that I might be working on this
> subject, as I announced here last month and care if you break my  
> work in
> any way.
> Then, you also "forgot" to wait for the fixes needed to address
> regression that have been introduced by previous inconsidered  
> commits in
> PowerPC emulation: I also said that this was the _first thing_ to be
> done before anything else in PowePC code.
> Then, I can be sure that you "forgot" to test if your patch breaks any
> PowerPC targets, as some do not run now...

Excuse me, I have not been able to run Linux on a single ppc target  
within the last _year_. Something is severely broken all that time,  
not just now.

> Last but not least, you also "forgot" to submit your patch, wait for
> comments, reviews, tests...
>
> All this is unacceptable;

As reported by René some months ago, you submitted a binary OHW update  
(r3309) but neither updated the source on your website nor QEMU's diff  
against it. Probably you just forgot, but don't be so harsh to others  
then. It's good to see that someone still cares about the PowerPC  
targets at all! Apart from Laurent, no one cared to review his OHW  
patch since then (not even complaining that it's whitespace-damaged).  
Nor did anyone complain that the PowerPC 'patch' by Salvatore was no  
patch at all but a gzipped tarball of apparently modified 0.9.1 source  
files - not yet reviewed at all this month.

Last month you actually said you were *planning* to port Alpha and  
PowerPC, with Alpha first, but had no time and reference hardware -  
your last commit is over half a year ago, so since there were no Alpha  
commits no one would expect you to work on PowerPC already given your  
statement. Most conversions to TCG (including the original  
introduction) were done without testing periods, step-by-step on  
trunk. Please don't fight over who's code gets committed, rather  
combine your efforts to get ppc usable again. If you'd post a link to  
your branch with work-in-progress like malc does that might help keep  
collisions low.

Thanks,
Andreas