[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [5063] Parallel Port Direction Fix
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [5063] Parallel Port Direction Fix |
Date: |
Fri, 22 Aug 2008 11:44:48 +0100 |
User-agent: |
Mutt/1.5.12-2006-07-14 |
Vijay Kumar, le Fri 22 Aug 2008 15:04:22 +0530, a écrit :
> Aurelien Jarno wrote:
> >Modified: trunk/qemu-char.h
> >===================================================================
> >--- trunk/qemu-char.h 2008-08-21 23:03:15 UTC (rev 5062)
> >+++ trunk/qemu-char.h 2008-08-22 08:57:09 UTC (rev 5063)
> >@@ -27,6 +27,7 @@
> > #define CHR_IOCTL_PP_EPP_READ 9
> > #define CHR_IOCTL_PP_EPP_WRITE_ADDR 10
> > #define CHR_IOCTL_PP_EPP_WRITE 11
> >+#define CHR_IOCTL_PP_DATA_DIR 12
> >
> > #define CHR_IOCTL_SERIAL_SET_TIOCM 12
> > #define CHR_IOCTL_SERIAL_GET_TIOCM 13
>
> Jarno, thanks for committing the patch. But it seems that now there are two
> IOCTL macros with the same value. To be safe we can move
> CHR_IOCTL_PP_DATA_DIR to 14.
Or we can push the serial ioctls. All the code using it gets recompiled
anyway.
Samuel