[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [5026] i386: fix isapc machine
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [5026] i386: fix isapc machine |
Date: |
Wed, 20 Aug 2008 16:28:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Aurelien Jarno wrote:
> Revision: 5026
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5026
> Author: aurel32
> Date: 2008-08-19 12:55:20 +0000 (Tue, 19 Aug 2008)
>
> Log Message:
> -----------
> i386: fix isapc machine
>
> - cirrus vga: enable graphic console
> - pc: don't use apic for interrupts on ISA machine
>
...
> Modified: trunk/hw/pc.c
> ===================================================================
> --- trunk/hw/pc.c 2008-08-18 18:00:31 UTC (rev 5025)
> +++ trunk/hw/pc.c 2008-08-19 12:55:20 UTC (rev 5026)
> @@ -121,10 +121,14 @@
> if (!level)
> return;
>
> - while (env) {
> - if (apic_accept_pic_intr(env))
> - apic_local_deliver(env, APIC_LINT0);
> - env = env->next_cpu;
> + if (env->apic_state) {
> + while (env) {
> + if (apic_accept_pic_intr(env))
> + apic_local_deliver(env, APIC_LINT0);
> + env = env->next_cpu;
> + }
> + } else {
> + cpu_interrupt(env, CPU_INTERRUPT_HARD);
> }
> }
Considering our recent experience with the APIC path, and also when
looking at old qemu versions, just asserting CPU_INTERRUPT_HARD won't be
enough. We also need cpu_reset_interrupt in the (!level) case. Will post
a patch, along with a rebased version for the APIC fix.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux