qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD host s


From: Todd T. Fries
Subject: Re: [Qemu-devel] [RFC, PATCH] Host AIO support detection, OpenBSD host support
Date: Fri, 15 Aug 2008 15:29:43 -0500
User-agent: Mutt/1.5.17 (2007-11-01)

Actually, the problem is that some driver lists (NetBSD in particular)
were changed to
        list="<a> <b> <c>"
while others (OpenBSD in particular) were left with
        list="a b c"

fun!
-- 
Todd Fries .. address@hidden

 _____________________________________________
|                                             \  1.636.410.0632 (voice)
| Free Daemon Consulting, LLC                 \  1.405.227.9094 (voice)
| http://FreeDaemonConsulting.com             \  1.866.792.3418 (FAX)
| "..in support of free software solutions."  \          250797 (FWD)
|                                             \
 \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
                                                 
              37E7 D3EB 74D0 8D66 A68D  B866 0326 204E 3F42 004A
                        http://todd.fries.net/pgp.txt

Penned by Blue Swirl on 20080815 23:05.40, we have:
| On 8/14/08, malc <address@hidden> wrote:
| > On Wed, 13 Aug 2008, Blue Swirl wrote:
| >
| >
| > > On 8/12/08, Anthony Liguori <address@hidden> wrote:
| > >
| > > > Blue Swirl wrote:
| > > >
| > > >
| > > > > Here are two patches, loosely based on patches in OpenBSD ports system
| > > > > that enable compiling Qemu. The first patch makes AIO use conditional
| > > > > on host AIO support. The second one adjusts various include files etc.
| > > > >
| > > > > I'd like to commit both of these, is that OK?
| > > > >
| > > > >
| > > > >
| > > >
| > > >  The first patch is fine but the second patch has some bogus things in
| > it.
| > > >
| > >
| > > Thanks for the review. I removed the unneeded parts, made a separate
| > > patch for fixing OSS selection, and added a configure option for AIO
| > > as requested by Samuel Thibault.
| > >
| >
| >  Thanks for the OSS bits, i have committed slightly modified patch that
| >  takes all possible drivers into consideration.
| 
| Great, but there is a bug in your commit, *) case seems to be checked
| before oss|sdl... case gets into play so the error is still present:
| 
| Error: Unknown driver 'oss' selected
| Possible drivers are: oss sdl esd
| 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]