Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu

[Samuel Thibault]

Gerd Hoffmann, le Wed 06 Aug 2008 12:14:25 +0200, a écrit :
> The rough way to merge would look like this:
> 
>   - drop xen_console.[ch]
>   - drop xenfb.[ch]
>   - drop xen_machine_pv.c
> 
>   - add xen.h
>   - add xen-machine.c
>   - add xen-backend.[ch]
>   - add xen-console.c
>   - add xen-framebuffer.c
> 
>   - wind up stuff in the Makefiles.
>   - some global renames (domid -> xen_domid for example) as I took care
>     to prefix global xen variables & functions with xen_.
>   - probably some small fixups are needed ...

You forgot the _test_ stage.  You are basically asking us to replace our
well-tested implementation with your implementation, that's quite a
move.  You are not even providing a patch for us to check that nothing
has been left behind...

> Note that qemu-dm has a few optimizations in the qemu display code to
> avoid unneeded work.  I'd suggest to submit them upstream.

That's planned, yes.  But you too could do the same for the device
backend core for instance...

> The you can gradually move qemu-dm to be more upstream-ish while also
> updating xend accordingly.

That's what we are already doing in Ian's tree.

Samuel