|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] upgrading emulated UART to 16550A |
Date: | Tue, 05 Aug 2008 21:28:25 -0500 |
User-agent: | Thunderbird 2.0.0.14 (X11/20080501) |
Stefano Stabellini wrote:
This patch upgrades the emulated UART to 16550A, the code comes from xen-unstable. The main improvement was introduced with the following patch and subsequent email thread: http://lists.xensource.com/archives/html/xen-devel/2007-12/msg00129.html
Very nice. Improving serial port emulation is on my list of TODO items so I'm glad to see this :-)
I only made few changes to use qemu_get_clock instead of clock_gettime, as Anthony suggested a little while ago.
I'll do a more thorough review on your next submission but one thing I wanted to point out, is that a lot of machine types rely on the serial emulation. While this patch has been tested in Xen, presumably, we need to make sure to do a fair bit of testing with non-x86 targets.
Regards, Anthony Liguori
Signed-off-by: Stefano Stabellini <address@hidden> ---
[Prev in Thread] | Current Thread | [Next in Thread] |